feat: annotation layers CRUD list view#11432
Merged
nytai merged 4 commits intoapache:masterfrom Oct 28, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11432 +/- ##
==========================================
+ Coverage 66.65% 66.66% +0.01%
==========================================
Files 863 864 +1
Lines 41048 41113 +65
Branches 3693 3706 +13
==========================================
+ Hits 27359 27409 +50
- Misses 13592 13606 +14
- Partials 97 98 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
reviewed
Oct 27, 2020
superset/annotation_layers/api.py
Outdated
Member
There was a problem hiding this comment.
Why do we need changed_on? it's better to use changed_on_delta_humanized, also if we need/want created_on we should add a created_on_delta_humanized
nytai
approved these changes
Oct 27, 2020
Member
nytai
left a comment
nytai
left a comment
There was a problem hiding this comment.
LGTM as a WIP. Let's get the python lint error fixed and I'll merge
riahk
force-pushed
the
moriah/annotation-layers-list
branch
2 times, most recently
from
c390145 to
0fb5e9f
Compare
riahk
force-pushed
the
moriah/annotation-layers-list
branch
from
e1e0c1a to
be14717
Compare
nytai
reviewed
Oct 29, 2020
| import { ListViewError, useListViewState } from './utils'; | ||
|
|
||
| const ListViewStyles = styled.div` | ||
| background: ${({ theme }) => theme.colors.grayscale.light5}; |
Member
There was a problem hiding this comment.
I should have caught this during review, but this line needs to be removed.
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
This was referenced Nov 26, 2023
This was referenced Dec 14, 2023
This was referenced Dec 20, 2023
mistercrunch
added
🏷️ bot
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
SIP_34_ANNOTATIONS_UIfeature flagBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
AnnotationLayersListADDITIONAL INFORMATION